Fix lidar resolution description about interpolation #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mabel Zhang <[email protected]>
ahcorde
approved these changes
Mar 5, 2021
|
Thanks for the review! I don't have permission in this repo to merge, so anyone else feel free to merge :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes description about when interpolation is done in
<lidar><scan><horizontal | vertical><resolution>.Summary
The current description says "If resolution is less than one, range data is interpolated. If resolution is greater than one, range data is averaged."
But in the actual
RaySensorimplementation in both Gazebo 9 and 11, interpolation is done whenever resolution != 1.interpis set totruewheneverrayCount != rangeCount(in SDF parameters' terms, that issamples != samples * resolution):https://github.com/osrf/gazebo/blob/d94e2e0b6754a929c11dec4dff2131cfd291478e/gazebo/sensors/RaySensor.cc#L412-L413
This PR updates the description to match the implementation.
Checklist
Added testsUpdated migration guide (as needed)sh tools/code_check.sh)test coverage)
another open pull request
to support the maintainers
@iche033
Note to maintainers: Remember to use Squash-Merge